From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Thu, 30 Jul 2015 03:08:48 -0700 Subject: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner. In-Reply-To: <20150730094738.GD488@griffinp-ThinkPad-X1-Carbon-2nd> References: <1435158670-7195-1-git-send-email-peter.griffin@linaro.org> <1435158670-7195-3-git-send-email-peter.griffin@linaro.org> <1435195057.9377.18.camel@perches.com> <20150722185811.2d718baa@recife.lan> <20150730094738.GD488@griffinp-ThinkPad-X1-Carbon-2nd> Message-ID: <1438250928.2677.10.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote: > Hi Mauro / Joe, > > On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote: > > > Em Wed, 24 Jun 2015 18:17:37 -0700 > > Joe Perches escreveu: > > > > > On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote: > > > > This is used in conjunction with the STV0367 demodulator on > > > > the STV0367-NIM-V1.0 NIM card which can be used with the STi > > > > STB SoC's. > > > > > > Barely associated to this specific patch, but for > > > dvb-pll.c, another thing that seems possible is to > > > convert the struct dvb_pll_desc uses to const and > > > change the "entries" fixed array size from 12 to [] > > > > > > It'd save a couple KB overall and remove ~5KB of data. > > > > > > $ size drivers/media/dvb-frontends/dvb-pll.o* > > > text data bss dec hex filename > > > 8520 1552 2120 12192 2fa0 drivers/media/dvb-frontends/dvb-pll.o.new > > > 5624 6363 2120 14107 371b drivers/media/dvb-frontends/dvb-pll.o.old > > > > Peter, > > > > Please add this patch on the next patch series you submit. > > Ok will do, I've added this patch with a slightly updated commit message > to my series. > > Joe - Can I add your signed-off-by? Signed-off-by: Joe Perches From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner. Date: Thu, 30 Jul 2015 03:08:48 -0700 Message-ID: <1438250928.2677.10.camel@perches.com> References: <1435158670-7195-1-git-send-email-peter.griffin@linaro.org> <1435158670-7195-3-git-send-email-peter.griffin@linaro.org> <1435195057.9377.18.camel@perches.com> <20150722185811.2d718baa@recife.lan> <20150730094738.GD488@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150730094738.GD488@griffinp-ThinkPad-X1-Carbon-2nd> Sender: linux-kernel-owner@vger.kernel.org To: Peter Griffin Cc: Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, lee.jones@linaro.org, hugues.fruchet@st.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote: > Hi Mauro / Joe, > > On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote: > > > Em Wed, 24 Jun 2015 18:17:37 -0700 > > Joe Perches escreveu: > > > > > On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote: > > > > This is used in conjunction with the STV0367 demodulator on > > > > the STV0367-NIM-V1.0 NIM card which can be used with the STi > > > > STB SoC's. > > > > > > Barely associated to this specific patch, but for > > > dvb-pll.c, another thing that seems possible is to > > > convert the struct dvb_pll_desc uses to const and > > > change the "entries" fixed array size from 12 to [] > > > > > > It'd save a couple KB overall and remove ~5KB of data. > > > > > > $ size drivers/media/dvb-frontends/dvb-pll.o* > > > text data bss dec hex filename > > > 8520 1552 2120 12192 2fa0 drivers/media/dvb-frontends/dvb-pll.o.new > > > 5624 6363 2120 14107 371b drivers/media/dvb-frontends/dvb-pll.o.old > > > > Peter, > > > > Please add this patch on the next patch series you submit. > > Ok will do, I've added this patch with a slightly updated commit message > to my series. > > Joe - Can I add your signed-off-by? Signed-off-by: Joe Perches