From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] build: use correct qemu path in systemd
 service file and init script
Date: Thu, 30 Jul 2015 12:35:10 +0100
Message-ID: <1438256110.11600.313.camel@citrix.com>
References: <1437983963.28924.19.camel@citrix.com>
	<1438239070-19525-1-git-send-email-lantw44@gmail.com>
	<1438251887.11600.288.camel@citrix.com>
	<20150730112348.GO1379@perard.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150730112348.GO1379@perard.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Ting-Wei Lan <lantw44@gmail.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-30 at 12:23 +0100, Anthony PERARD wrote:
> On Thu, Jul 30, 2015 at 11:24:47AM +0100, Ian Campbell wrote:
> > On Thu, 2015-07-30 at 14:51 +0800, Ting-Wei Lan wrote:
> > > When --with-system-qemu is used, it is possible that we cannot find
> > > qemu-system-i386 in LIBEXEC_BIN, which can cause error in xencommons
> > > init script and xen-qemu-dom0-disk-backend.service systemd service.
> > > 
> > > Signed-off-by: Ting-Wei Lan <lantw44@gmail.com>
> > 
> > Personally I would have omitted the distinction between @qemu_xen_path@ 
> > and
> > @qemu_xen_systemd@ and just put the env invocation in the service file 
> > as
> > "/usr/bin/env @qemu_xen_path@" but I suppose that is just bike 
> > shedding,
> > so:
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > Wei Lui, what do you think about this for 4.6? It fixes a real issue 
> > where 
> > --with-system-qemu is used without an explicit path, which is supposed 
> > to
> > search for "qemu" in $PATH but fails to do so for the initscripts and 
> > unit
> > files, where it uses the old hardcoded default value instead, which
> > probably doesn't exist if you are using this option (and if it did 
> > isn't
> > the thing the user asked for).
> > 
> > The fix looks pretty straight forward to me.
> > 
> > Mostly unrelated, is "qemu" a sensible default here? No binary package 
> > on
> > Debian actually provides a "qemu" binary, they are all qemu-system-foo 
> > or
> > variants. I'm not sure if that's just a Debian packaging issue though. 
> > I've
> > added the Qemu-xen maintainers for input...
> 
> QEMU does not build a binary called 'qemu', so this would be package
> specific. So I think a default should be either 'qemu-system-i386' or 
> fail if no path is provided.

Thanks. I think we should take Ting-Wei's patch as is for 4.6 and fixup the
default to be qemu-system-i386 in 4.7.

Ian.