All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaehyun Lim <chaehyun.lim@gmail.com>
To: gregkh@linuxfoundation.org
Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com,
	chris.park@atmel.com, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org, Chaehyun Lim <chaehyun.lim@gmail.com>
Subject: [RESEND V2 0/3] cover letter of wilc1000 patches
Date: Thu, 30 Jul 2015 20:41:02 +0900	[thread overview]
Message-ID: <1438256465-19540-1-git-send-email-chaehyun.lim@gmail.com> (raw)

Hi, Greg

I'm sorry that I did not say whether GFP_ATOMIC should be used or not.
This is my review on it. If it's not correct, please give me any comment or direction.

First patch has 4 sites of kmalloc change in coreconfigurator.c
First one, it is used for gps8ConfigPacket at CoreconfiguratorInit and CoreConfiguratorDeInit.
I think it should be removed next time because I cannot find anywhere to use it.
Then, it is okay to change flag as GFP_KERNEL.

Other three changes are used to handle host interface message within a kernel thread.
The manipulation of host interface message is not called on IRQ context and I could not
find any spin lock inside function.

If this patches are accepted, I will try to continue to change WILC_MALLOC macro as kmalloc.
I always appreciate your comment and advice.

Thanks
Chaehyun Lim


Chaehyun Lim (3):
  staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC
  staging: wilc1000: coreconfigurator.c: add kmalloc error check
  staging: wilc1000: coreconfigurator.c: fix kmalloc error check

 drivers/staging/wilc1000/coreconfigurator.c | 38 +++++++++++++++++------------
 1 file changed, 23 insertions(+), 15 deletions(-)

-- 
1.9.1


             reply	other threads:[~2015-07-30 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 11:41 Chaehyun Lim [this message]
2015-07-30 11:41 ` [RESEND V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC Chaehyun Lim
2015-07-30 11:41 ` [RESEND V2 2/3] staging: wilc1000: coreconfigurator.c: add kmalloc error check Chaehyun Lim
2015-07-30 11:41 ` [RESEND V2 3/3] staging: wilc1000: coreconfigurator.c: fix " Chaehyun Lim
2015-07-30 12:03 ` [RESEND V2 0/3] cover letter of wilc1000 patches Chaehyun Lim
2015-07-30 12:18   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438256465-19540-1-git-send-email-chaehyun.lim@gmail.com \
    --to=chaehyun.lim@gmail.com \
    --cc=chris.park@atmel.com \
    --cc=dean.lee@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.