From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA
Date: Fri, 31 Jul 2015 10:29:36 +0100
Message-ID: <1438334976.30740.30.camel@citrix.com>
References: <1438272689-29944-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=647690e37=Ian.Campbell@citrix.com>)
	id 1ZL6dP-0002qQ-1H
	for xen-devel@lists.xenproject.org; Fri, 31 Jul 2015 09:29:47 +0000
In-Reply-To: <1438272689-29944-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:
> Update xl manual and disable PV vNUMA in libxl.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---

Acked-by: Ian Campbell <ian.campbell@citrix.com>

and applied.

>  
> +    /* PV vNUMA is not yet supported because there is an issue with
> +     * cpuid handling.
> +     */

Personally I think this is wrong and should be
    /*
     * PV vNUMA...

but a) there are a bunch of similarly formatted comments in this function
and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.

So I left it.

Ian.