From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [osstest test] 60149: regressions - FAIL
Date: Fri, 31 Jul 2015 10:54:09 +0100
Message-ID: <1438336449.30740.37.camel@citrix.com>
References: <osstest-60149-mainreport@xen.org>
	<1438324802.28924.44.camel@citrix.com>
	<1438336042.30740.34.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1438336042.30740.34.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: osstest service owner <osstest-admin@xenproject.org>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-31 at 10:47 +0100, Ian Campbell wrote:
> 2015-07-30 23:02:32 Z runvar store:
> > redhat_cfgpath=/etc/xen/redhat.guest.osstest.cfg
> > 2015-07-30 23:02:32 Z executing scp ... /home/logs/logs/60149/test
> > -amd64
> > -i386-qemuu-rhel6hvm-amd/pinot1--redhat.guest.osstest.cfg 
> > root@172.16.144.35:/etc/xen/redhat.guest.osstest.cfg
> > 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35        
> >  (echo 
> > xenvnc; echo xenvnc) | vncpasswd redhat.vncpw
> > 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 readlink 
> > /dev/pinot1/redhat.guest.osstest-disk
> > 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 lvdisplay -
> > -colon /dev/pinot1/redhat.guest.osstest-disk
> > Can't call method "create" on unblessed reference at 
> > Osstest/TestSupport.pm line 1436.
> 
> I can't explain this one yet.
> 
> Calling a method on an undefined value results in a different message,
> "Can't call method "create" on an undefined value", so somehow
> toolstack($ho) is an actual reference, but an unblessed one. I haven't
> figured out how that can have happened yet.

$ cat t.pl
#!/usr/bin/perl -w

use strict;

my $foo = {};

my $baz = $foo->{Bar}->{Name} =~ m/123/ ? "A" : "B";

print "$baz\n";
$foo->{Bar}->create();
$ ./t.pl
Use of uninitialized value in pattern match (m//) at /home/ianc/t.pl line 7.
B
Can't call method "create" on unblessed reference at /home/ianc/t.pl line 10.

Whereas with:
    my $baz = $foo->{Bar} =~ m/123/ ? "A" : "B";
the error is:
    Can't call method "create" on an undefined value at /home/ianc/t.pl line 10.

IOW something about:
    $foo->{Bar}->{Name} =~ m/123/ ? "A" : "B";
causes $foo->{Bar} to be initialised.

IOW I think the fix to more_prepareguest_hvm is going to fix this too.

I'll fold that in, drop the patch which does make test and force push to
osstest's pretest, then I'll kill the current flight.

Ian.