From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA
Date: Fri, 31 Jul 2015 12:04:13 +0200
Message-ID: <1438337053.16912.88.camel@citrix.com>
References: <1438272689-29944-1-git-send-email-wei.liu2@citrix.com>
	<1438334976.30740.30.camel@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7287171578262902880=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=647f4ebfe=dario.faggioli@citrix.com>)
	id 1ZL7Aw-00054H-Iw
	for xen-devel@lists.xenproject.org; Fri, 31 Jul 2015 10:04:26 +0000
In-Reply-To: <1438334976.30740.30.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============7287171578262902880==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-/ucrHTBRBR0TUFQ3kOgW"

--=-/ucrHTBRBR0TUFQ3kOgW
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-07-31 at 10:29 +0100, Ian Campbell wrote:
> On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:

> > =20
> > +    /* PV vNUMA is not yet supported because there is an issue with
> > +     * cpuid handling.
> > +     */
>=20
> Personally I think this is wrong and should be
>     /*
>      * PV vNUMA...
>=20
Me too...

> but a) there are a bunch of similarly formatted comments in this function
>
Exactly.

> and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.
>=20
Should we make it do so? FWIW, I'd say we should (and can send a patch
to the effect...)

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

--=-/ucrHTBRBR0TUFQ3kOgW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlW7SB0ACgkQk4XaBE3IOsRLEwCaAvbi3HS9PhO/VssM0T5Oy3cF
9sQAoI8Ir0+C7p4OVhSDG0VNTyku3hzt
=mphz
-----END PGP SIGNATURE-----

--=-/ucrHTBRBR0TUFQ3kOgW--


--===============7287171578262902880==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7287171578262902880==--