From: Kinsella, Ray <ray.kinsella@intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v2] Build El Torito for i386 PC
Date: Fri, 31 Jul 2015 16:02:37 +0000 [thread overview]
Message-ID: <1438358553.3808.4.camel@intel.com> (raw)
In-Reply-To: <20150729173643.18dabf28@free-electrons.com>
Hi Thomas,
> And I tested your patch, and it fails to build. So it seems like you
> did not test it properly.
humble apologies, I thought it was fine - clearly I made a mistake
somewhere.
> The reason is that the $(GRUB2_IMAGE) used by
> your new post-install hook is not generated until the next post-install
> hook (the existing GRUB2_IMAGE_INSTALLATION function) gets executed. But
> this hook is afterwards.
Moving ELTORITO to after GRUB2_IMAGE_INSTALLATION would have fixed it
also
then. I originally had my code exactly like this yours then didn't want
to
pollute GRUB2_IMAGE_INSTALLATION with the GRUB2_IMAGE_INSTALL_ELTORITO
which
may be empty.
>
> So I changed the implementation to simply make the
> GRUB2_IMAGE_INSTALLATION function call GRUB2_IMAGE_INSTALL_ELTORITO.
np, small change.
Thanks,
Ray K
prev parent reply other threads:[~2015-07-31 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 11:52 [Buildroot] [PATCH 1/1 v2] Build El Torito for i386 PC Kinsella, Ray
2015-07-29 15:36 ` Thomas Petazzoni
2015-07-31 16:02 ` Kinsella, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438358553.3808.4.camel@intel.com \
--to=ray.kinsella@intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.