From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:59666 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751338AbbGaWMM (ORCPT
	<rfc822;stable@vger.kernel.org>); Fri, 31 Jul 2015 18:12:12 -0400
Message-ID: <1438380729.32093.11.camel@perches.com>
Subject: Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf
 extension %pV instead" has been added to the 3.10-stable tree
From: Joe Perches <joe@perches.com>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	torvalds@linux-foundation.org, stable@vger.kernel.org,
	stable-commits@vger.kernel.org
Date: Fri, 31 Jul 2015 15:12:09 -0700
In-Reply-To: <alpine.DEB.2.00.1507312324350.16946@leontynka>
References: <1438371469111133@kroah.com>
	 <1438371755.19675.136.camel@perches.com> <20150731200333.GA15198@kroah.com>
	 <1438374923.32093.3.camel@perches.com>
	 <alpine.DEB.2.00.1507312324350.16946@leontynka>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Fri, 2015-07-31 at 23:27 +0200, Mikulas Patocka wrote:
> On Fri, 31 Jul 2015, Joe Perches wrote:
> 
> > On Fri, 2015-07-31 at 13:03 -0700, Greg KH wrote:
> > > On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> > > > On Fri, 2015-07-31 at 12:37 -0700,  
> gregkh@linuxfoundation.orgwrote:
> > > > > This is a note to let you know that I've just added the 
> patch 
> > > > > titled
> > > > > 
> > > > >     hpfs: hpfs_error: Remove static buffer, use vsprintf 
> > > > > extension %pV instead
> > > > > 
> > > > > to the 3.10-stable tree which can be found at:
> > > > >     
> > > > > 
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > > 
> > > > While I know this patch reduces some code and text,
> > > > it's not correcting any defect in the code, it's
> > > > only a minor optimization.
> > > > 
> > > > Is it really appropriate for stable?
> > > 
> > > I agree, why was it marked that way?  I assumed it was due to 
> the 
> > > patch
> > > after it needed it, but maybe not.  Any objection to me just 
> dropping
> > > it?
> > 
> > Not from me.
> > 
> > I think Mikulas marked it for stable.
> > 
> > Mikulas?
> 
> The bug corrected by the patch is - if hpfs_error is called 
> concurrently 
> on multiple filesystems, it could corrupt the string because the 
> text 
> buffer is shared. That's why I marked the patch for stable.

OK then.  If you noticed that when you marked it
for stable, it would have been nicer to update the
commit message to show a bug fix too.

cheers, Joe