From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] sunxi: usb-phy: Never power off the usb ports
Date: Sun, 02 Aug 2015 17:25:12 +0100 [thread overview]
Message-ID: <1438532712.18644.15.camel@hellion.org.uk> (raw)
In-Reply-To: <1438433451-17720-1-git-send-email-hdegoede@redhat.com>
On Sat, 2015-08-01 at 14:50 +0200, Hans de Goede wrote:
> USB devices are not really designed to get the power bounced off and on
> at them. Esp. USB powered harddisks do not like this.
>
> Currently we power off the USB ports both on a "usb reset" and when
> booting the kernel, causing the usb-power to bounce off and then back
> on again.
>
> This patch removes the powering off calls, fixing the undesirable power
> bouncing.
>
> Note this requires some special handling for the OTG port:
> 1) We must skip the external vbus check if we've already enabled our own
> vbus to avoid false positives
> 2) If on an usb reset we no longer detect that the id-pin is grounded, turn
> off vbus as that means an external vbus may be present now
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
prev parent reply other threads:[~2015-08-02 16:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 12:50 [U-Boot] [PATCH 1/3] sunxi: usb-phy: Never power off the usb ports Hans de Goede
2015-08-01 12:50 ` [U-Boot] [PATCH 2/3] sunxi: Add CONFIG_USB0_ID_DET setting to 2 more tablets Hans de Goede
2015-08-02 16:25 ` Ian Campbell
2015-08-01 12:50 ` [U-Boot] [PATCH 3/3] sunxi: Do not add a stdout-path alias to dts on boards without a serial port Hans de Goede
2015-08-02 16:28 ` Ian Campbell
2015-08-02 18:45 ` Hans de Goede
2015-08-02 18:57 ` Ian Campbell
2015-08-03 7:44 ` Hans de Goede
2015-08-02 16:25 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438532712.18644.15.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.