Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

[Joe Perches <joe@perches.com>]

On Mon, 2015-08-03 at 09:15 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 05:53:22AM +0000, Wang, Biao wrote:
> > Consider the following case:
> > Task A trigger lmk with a lock held, while task B try to
> > get this lock, but unfortunately B is the very culprit task lmk 
> > select to
> > kill. Then B will never be killed, and A will forever select B to 
> > kill.
> > Such dead lock will trigger softlock up issue.
> > 
> > This patch try to pick the next task to break this loop.
> > 
> > Signed-off-by: Wang Biao <biao.wang@intel.com>
> > Reviewed-by: Zhang Di <di.zhang@intel.com>
> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> I don't really feel comfortable saying I reviewed this code.  I just
> commented on a few process issues.  I don't know the subsystem well
> enough to give it a seal of approval.
> 
> > Reviewed-by: Joe Perches <joe@perches.com>

Please don't say I reviewed this either.

I may have commented on it, but I certainly
did't add a "Reviewed-by" signature.

Please don't add signatures unless people
specifically state so.