From: Joe Perches <joe@perches.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>
Date: Mon, 03 Aug 2015 08:28:48 -0700 [thread overview]
Message-ID: <1438615728.30149.31.camel@perches.com> (raw)
In-Reply-To: <20150803131020.GA26870@sgi.com>
On Mon, 2015-08-03 at 08:10 -0500, Dimitri Sivanich wrote:
> This should be %d, not 0x%x.
I don't care one way or the other, but
please fix it so it matches.
> > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> > index ae16c8c..a1ce324 100644
> > --- a/drivers/misc/sgi-gru/grumain.c
> > +++ b/drivers/misc/sgi-gru/grumain.c
> > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
> > spin_lock(&gru->gs_asid_lock);
> > BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
> > asids->mt_ctxbitmap ^= ctxbitmap;
> > - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> > + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
> > gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
> > spin_unlock(&gru->gs_asid_lock);
> > spin_unlock(&gms->ms_asid_lock);
prev parent reply other threads:[~2015-08-03 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 20:27 [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches
2015-08-03 13:10 ` Dimitri Sivanich
2015-08-03 15:28 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438615728.30149.31.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.