From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932104AbbHCP2x (ORCPT ); Mon, 3 Aug 2015 11:28:53 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:57869 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753319AbbHCP2v (ORCPT ); Mon, 3 Aug 2015 11:28:51 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3872:4321:4605:5007:6119:6261:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: order82_6a3bf3ad59563 X-Filterd-Recvd-Size: 1724 Message-ID: <1438615728.30149.31.camel@perches.com> Subject: Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x From: Joe Perches To: Dimitri Sivanich Cc: linux-kernel@vger.kernel.org Date: Mon, 03 Aug 2015 08:28:48 -0700 In-Reply-To: <20150803131020.GA26870@sgi.com> References: <1438547247.29569.7.camel@perches.com> <20150803131020.GA26870@sgi.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.16.0-fta1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-08-03 at 08:10 -0500, Dimitri Sivanich wrote: > This should be %d, not 0x%x. I don't care one way or the other, but please fix it so it matches. > > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c > > index ae16c8c..a1ce324 100644 > > --- a/drivers/misc/sgi-gru/grumain.c > > +++ b/drivers/misc/sgi-gru/grumain.c > > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru, > > spin_lock(&gru->gs_asid_lock); > > BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); > > asids->mt_ctxbitmap ^= ctxbitmap; > > - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n", > > + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n", > > gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]); > > spin_unlock(&gru->gs_asid_lock); > > spin_unlock(&gms->ms_asid_lock);