* [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>
@ 2015-08-02 20:27 Joe Perches
2015-08-03 13:10 ` Dimitri Sivanich
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-08-02 20:27 UTC (permalink / raw)
To: Dimitri Sivanich; +Cc: linux-kernel
Correct misuse of 0x%d in logging message.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/misc/sgi-gru/grumain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index ae16c8c..a1ce324 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
spin_lock(&gru->gs_asid_lock);
BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
asids->mt_ctxbitmap ^= ctxbitmap;
- gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
+ gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
spin_unlock(&gru->gs_asid_lock);
spin_unlock(&gms->ms_asid_lock);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>
2015-08-02 20:27 [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches
@ 2015-08-03 13:10 ` Dimitri Sivanich
2015-08-03 15:28 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Dimitri Sivanich @ 2015-08-03 13:10 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel
This should be %d, not 0x%x.
Nacked-by: Dimitri Sivanich <sivanich@sgi.com>
On Sun, Aug 02, 2015 at 01:27:27PM -0700, Joe Perches wrote:
> Correct misuse of 0x%d in logging message.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/misc/sgi-gru/grumain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..a1ce324 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
> spin_lock(&gru->gs_asid_lock);
> BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
> asids->mt_ctxbitmap ^= ctxbitmap;
> - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
> gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
> spin_unlock(&gru->gs_asid_lock);
> spin_unlock(&gms->ms_asid_lock);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal>
2015-08-03 13:10 ` Dimitri Sivanich
@ 2015-08-03 15:28 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2015-08-03 15:28 UTC (permalink / raw)
To: Dimitri Sivanich; +Cc: linux-kernel
On Mon, 2015-08-03 at 08:10 -0500, Dimitri Sivanich wrote:
> This should be %d, not 0x%x.
I don't care one way or the other, but
please fix it so it matches.
> > diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> > index ae16c8c..a1ce324 100644
> > --- a/drivers/misc/sgi-gru/grumain.c
> > +++ b/drivers/misc/sgi-gru/grumain.c
> > @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
> > spin_lock(&gru->gs_asid_lock);
> > BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
> > asids->mt_ctxbitmap ^= ctxbitmap;
> > - gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> > + gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
> > gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
> > spin_unlock(&gru->gs_asid_lock);
> > spin_unlock(&gms->ms_asid_lock);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-03 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-02 20:27 [TRIVIAL PATCH] sgi-gru: Correct misuse of %0x<decimal> Joe Perches
2015-08-03 13:10 ` Dimitri Sivanich
2015-08-03 15:28 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.