From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2] Arrange to test migration from
 the previous Xen version
Date: Mon, 3 Aug 2015 17:01:22 +0100
Message-ID: <1438617682.31129.29.camel@citrix.com>
References: <1437755305-17200-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437755305-17200-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-24 at 17:28 +0100, Ian Campbell wrote:
> @@ -191,6 +208,27 @@ create_build_jobs () {
>                  revision_ovmf=$REVISION_OVMF
>      done
>  
> +    if [ x$want_prevxen = xy ] ; then
> +        if [ "x$REVISION_PREVXEN" = x ] ; then
> +            echo >&2 "prevxen ?"; exit 1
> +        fi

This breaks things with standalone mode, or any make-flight which didn't
come from cr-daily-branch.

In such cases we don't have REVISION_XEN or TREE_XEN either, we just get
the defaults.

I think we need to do something like select_prevxenbranch but to pick a
xen.git branch name rather than an osstest branch name.

Or we quietly skip this test if REVISION_PREVXEN is not set.

One to chew on I think.

Ian.