From: Joe Perches <joe@perches.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG
Date: Mon, 03 Aug 2015 21:02:21 -0700 [thread overview]
Message-ID: <1438660941.10829.3.camel@perches.com> (raw)
In-Reply-To: <1438660677.10829.1.camel@perches.com>
On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote:
> On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote:
> > This patch replaces calls to net_dbg_ratelimited when !DEBUG with
> > no_printk, keeping with the idiom of all the other debug print helpers.
>
> Makes sense, thanks Jason.
Perhaps better still would be to use if (0) no_printk so that
the call and whatever argument calls the net_dbg_ratelimited
makes are completely eliminated.
next prev parent reply other threads:[~2015-08-04 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 3:26 [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG Jason A. Donenfeld
2015-08-04 3:57 ` Joe Perches
2015-08-04 4:02 ` Joe Perches [this message]
2015-08-04 4:59 ` David Miller
2015-08-04 15:07 ` Jason A. Donenfeld
2015-08-04 15:08 ` Jason A. Donenfeld
2015-08-04 15:51 ` Joe Perches
2015-08-04 16:26 ` [PATCH v3] " Jason A. Donenfeld
2015-08-07 6:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438660941.10829.3.camel@perches.com \
--to=joe@perches.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.