From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 v2 1/6] tools/libxl: Make libxl__conversion_helper_abort() safe to use Date: Tue, 4 Aug 2015 10:30:03 +0100 Message-ID: <1438680603.31129.64.camel@citrix.com> References: <1438617395-20329-1-git-send-email-andrew.cooper3@citrix.com> <1438617395-20329-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438617395-20329-2-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Mon, 2015-08-03 at 16:56 +0100, Andrew Cooper wrote: > Previously, in the case of an error causing a call to > libxl__conversion_helper_abort() on a stream without legacy conversion, > libxl would fall over a NULL pointer because chs->ao was not set up. > > Arrange for all ->ao's to be set up at _init() time, by having each > _init() function assert that their caller has done the right thing. > While doing so, introduce a previously-missing save_helper_init() in > stream_read_init(). > > Signed-off-by: Andrew Cooper > --- > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > > v2: Make sure ->ao is always valid I believe this + the extra comment in libxl__conversion_helper_state addresses Ian J's feedback from the previous round, so: Acked-by: Ian Campbell