From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v8 1/2] OSSTEST: introduce a raisin build
	test
Date: Tue, 4 Aug 2015 15:01:04 +0100
Message-ID: <1438696864.31129.122.camel@citrix.com>
References: <alpine.DEB.2.02.1507231749120.28668@kaball.uk.xensource.com>
	<1437670366-29034-1-git-send-email-stefano.stabellini@eu.citrix.com>
	<1438686271.31129.96.camel@citrix.com>
	<alpine.DEB.2.02.1508041208230.11337@kaball.uk.xensource.com>
	<1438688274.31129.103.camel@citrix.com>
	<alpine.DEB.2.02.1508041242020.11337@kaball.uk.xensource.com>
	<1438695690.31129.114.camel@citrix.com>
	<alpine.DEB.2.02.1508041446350.11337@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1508041446350.11337@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-08-04 at 14:47 +0100, Stefano Stabellini wrote:
> On Tue, 4 Aug 2015, Ian Campbell wrote:
> > On Tue, 2015-08-04 at 14:18 +0100, Stefano Stabellini wrote:
> > > On Tue, 4 Aug 2015, Ian Campbell wrote:
> > > > On Tue, 2015-08-04 at 12:18 +0100, Stefano Stabellini wrote:
> > > > > > It hasn't actually failed though, is that normal?
> > > > >  
> > > > > It is an "optional" dependency, without it passthrough is 
> > > > > disabled in
> > > > > qemu-traditional. Passing -n tell raisin to "shut up, do nothing 
> > > > > and
> > > > > continue", so at the end the build still succeed.
> > > > 
> > > > What other sorts of things are optional?
> > > 
> > > There isn't really a distinction between mandatory dependencies and
> > > optional dependencies in raisin. This is what raisin is currently
> > > complaining about:
> > > 
> > > bridge-utils pciutils-dev libnl-3-dev libnl-route-3-dev
> > > 
> > > bridge-utils is actually a run time dependency for Xen, while
> > > libnl-3-dev and libnl-route-3-dev are build time dependencies for
> > > libvirt. I think they are needed for vlan support. Should I add them
> > > too?
> > 
> > I think so, I have a feeling Remus might use them too? cf "[PATCH] 
> > osstest:
> > install libnl3 packages" from Roger.
> 
> Actually this is why I cannot remove the buildjob=${bfi}build-$arch
> line: otherwise the build deps don't get installed, right?

I don't think so, ts-xen-build-prep is badly named and is run for any build
job (formally I think anything in sg-run-job where need-hosts/FOO returns
BUILD).

Ian.