From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbbHDPvL (ORCPT ); Tue, 4 Aug 2015 11:51:11 -0400 Received: from smtprelay0133.hostedemail.com ([216.40.44.133]:59202 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750994AbbHDPvJ (ORCPT ); Tue, 4 Aug 2015 11:51:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:4321:5007:6261:8660:10004:10400:10848:11026:11232:11658:11914:12043:12114:12296:12438:12517:12519:12740:13069:13148:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pull98_43d6e90568d63 X-Filterd-Recvd-Size: 1968 Message-ID: <1438703465.10829.20.camel@perches.com> Subject: Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG From: Joe Perches To: "Jason A. Donenfeld" Cc: Andrew Morton , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 04 Aug 2015 08:51:05 -0700 In-Reply-To: <1438700836-6715-1-git-send-email-Jason@zx2c4.com> References: <20150803.215900.915316341182067498.davem@davemloft.net> <1438700836-6715-1-git-send-email-Jason@zx2c4.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-08-04 at 17:07 +0200, Jason A. Donenfeld wrote: > The pr_debug family of functions turns into a no-op when -DDEBUG is not > specified, opting instead to call "no_printk", which gets compiled to a > no-op (but retains gcc's nice warnings about printf-style arguments). [] > diff --git a/include/linux/net.h b/include/linux/net.h [] > @@ -239,8 +239,14 @@ do { \ > net_ratelimited_function(pr_warn, fmt, ##__VA_ARGS__) > #define net_info_ratelimited(fmt, ...) \ > net_ratelimited_function(pr_info, fmt, ##__VA_ARGS__) > +#if defined(DEBUG) > #define net_dbg_ratelimited(fmt, ...) \ > net_ratelimited_function(pr_debug, fmt, ##__VA_ARGS__) > +#else > +#define net_dbg_ratelimited(fmt, ...) \ > + if (0) \ > + no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) > +#endif This should be: #define net_dbg_ratelimited(fmt, ...) \ do { \ if (0) \ no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \ } while (0) to be safe in if/else uses