All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Antonio Quartulli <antonio@meshcoding.com>,
	Marek Lindner <mareklindner@neomailbox.ch>
Subject: [B.A.T.M.A.N.] [PATCH 14/14] batman-adv: Fix potentially broken skb network header access
Date: Tue,  4 Aug 2015 18:35:34 +0200	[thread overview]
Message-ID: <1438706134-3492-15-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1438706134-3492-1-git-send-email-antonio@meshcoding.com>

From: Linus Lüssing <linus.luessing@c0d3.blue>

The two commits noted below added calls to ip_hdr() and ipv6_hdr(). They
need a correctly set skb network header.

Unfortunately we cannot rely on the device drivers to set it for us.
Therefore setting it in the beginning of the according ndo_start_xmit
handler.

Fixes: 1d8ab8d3c176 ("batman-adv: Modified forwarding behaviour for multicast packets")
Fixes: ab49886e3da7 ("batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 net/batman-adv/soft-interface.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index a2fc843..51cda3a 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -202,6 +202,7 @@ static int batadv_interface_tx(struct sk_buff *skb,
 	int gw_mode;
 	enum batadv_forw_mode forw_mode;
 	struct batadv_orig_node *mcast_single_orig = NULL;
+	int network_offset = ETH_HLEN;
 
 	if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE)
 		goto dropped;
@@ -214,14 +215,18 @@ static int batadv_interface_tx(struct sk_buff *skb,
 	case ETH_P_8021Q:
 		vhdr = vlan_eth_hdr(skb);
 
-		if (vhdr->h_vlan_encapsulated_proto != ethertype)
+		if (vhdr->h_vlan_encapsulated_proto != ethertype) {
+			network_offset += VLAN_HLEN;
 			break;
+		}
 
 		/* fall through */
 	case ETH_P_BATMAN:
 		goto dropped;
 	}
 
+	skb_set_network_header(skb, network_offset);
+
 	if (batadv_bla_tx(bat_priv, skb, vid))
 		goto dropped;
 
-- 
2.5.0


  parent reply	other threads:[~2015-08-04 16:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 16:35 [B.A.T.M.A.N.] pull request [net]: batman-adv 20150804 Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 01/14] batman-adv: Replace gw_reselect divisor with simple shift Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 02/14] batman-adv: Avoid u32 overflow during gateway select Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 03/14] batman-adv: avoid DAT to mess up LAN state Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [PATCH 04/14] batman-adv: Make DAT capability changes atomic Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 05/14] batman-adv: Make NC " Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 06/14] batman-adv: Make TT " Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [PATCH 07/14] batman-adv: Make MCAST " Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 16:35 ` [PATCH 08/14] batman-adv: Fix potential synchronization issues in mcast tvlv handler Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 16:35 ` [PATCH 09/14] batman-adv: fix kernel crash due to missing NULL checks Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 16:35 ` [PATCH 10/14] batman-adv: protect tt_local_entry from concurrent delete events Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 16:35 ` [PATCH 11/14] batman-adv: protect tt request from double deletion Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 12/14] batman-adv: initialize up/down values when adding a gateway Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [B.A.T.M.A.N.] [PATCH 13/14] batman-adv: remove broadcast packets scheduled for purged outgoing if Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli
2015-08-04 16:35 ` [PATCH 14/14] batman-adv: Fix potentially broken skb network header access Antonio Quartulli
2015-08-04 16:35 ` Antonio Quartulli [this message]
2015-08-04 19:40 ` [B.A.T.M.A.N.] pull request [net]: batman-adv 20150804 David Miller
2015-08-04 19:40   ` David Miller
2015-08-04 19:50   ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-04 19:50     ` Antonio Quartulli
2015-08-04 20:25     ` Sven Eckelmann
2015-08-04 22:28       ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438706134-3492-15-git-send-email-antonio@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.