From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] create-pull-request: cd to relative directory
Date: Wed, 5 Aug 2015 12:01:51 +0300 [thread overview]
Message-ID: <1438765311-13423-1-git-send-email-ed.bartosh@linux.intel.com> (raw)
create-pull-request -d path creates empty patches if directory
is specified as a path, i.e. ./bitbake or ./bitbake/ or full path.
It behaves expected way only if script is run with -d bitbake, i.e.
relative dir name doesn't contain '\'.
Fixed this unwanted behaviour by changing directory and running
git format-patch in it with --relative, without specifying
relative path as a parameter.
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
scripts/create-pull-request | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/create-pull-request b/scripts/create-pull-request
index 216edfd..7eac618 100755
--- a/scripts/create-pull-request
+++ b/scripts/create-pull-request
@@ -177,12 +177,15 @@ mkdir $ODIR
if [ -n "$RELDIR" ]; then
ODIR=$(realpath $ODIR)
- extraopts="--relative=$RELDIR"
+ pushd $RELDIR
+ extraopts="--relative"
fi
# Generate the patches and cover letter
git format-patch $extraopts -M40 --subject-prefix="$PREFIX" -n -o $ODIR --thread=shallow --cover-letter $RELATIVE_TO..$COMMIT_ID > /dev/null
+[ -n "$RELDIR" ] && popd
+
# Customize the cover letter
CL="$ODIR/0000-cover-letter.patch"
PM="$ODIR/pull-msg"
--
2.1.4
next reply other threads:[~2015-08-05 9:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 9:01 Ed Bartosh [this message]
2015-08-06 3:33 ` [PATCH] create-pull-request: cd to relative directory Khem Raj
2015-08-06 8:38 ` Paul Eggleton
2015-08-06 9:07 ` Ed Bartosh
2015-08-06 15:05 ` Khem Raj
2015-08-06 15:16 ` Paul Eggleton
2015-08-06 16:16 ` Khem Raj
2015-08-11 14:24 ` [PATCH v2] " Ed Bartosh
2015-08-11 14:33 ` [PATCH v3] " Ed Bartosh
2015-08-12 9:33 ` [PATCH v4] create-pull-request: cleanup bashisms Ed Bartosh
2015-08-12 9:35 ` Khem Raj
2015-08-12 9:49 ` shell script guidelines in oe-core? (was Re: [PATCH v4] create-pull-request: cleanup bashisms) Mikko.Rapeli
2015-08-12 16:56 ` Khem Raj
2015-08-12 17:46 ` Christopher Larson
2015-08-12 17:51 ` Christopher Larson
2015-08-13 6:27 ` Mikko.Rapeli
2015-08-14 22:01 ` Christopher Larson
2015-08-16 1:38 ` Christopher Larson
2015-08-17 6:14 ` Mikko.Rapeli
2015-08-17 10:52 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438765311-13423-1-git-send-email-ed.bartosh@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.