From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 v3 0/6] Fix libxl TOOLSTACK records for migration v2 Date: Wed, 5 Aug 2015 10:58:56 +0100 Message-ID: <1438768736.9747.42.camel@citrix.com> References: <1438708596-21033-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438708596-21033-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Tue, 2015-08-04 at 18:16 +0100, Andrew Cooper wrote: > The libxl blob for toolstack records was not 32/64bit safe. In 64bit > builds, it had an extra 4 bytes of padding due to alignment, and because > of the pointer arithmatic used to build it, leaked 4 bytes of libxl heap > into the stream. > > Respecify XENSTORE_DATA as EMULATOR_XENSTORE_DATA and take remedial > action to prevent this bitness issue escaping into a Xen release. > > Only minor changes from v3. Details in patches. > > Summary of Modified/Acks: > > Andrew Cooper (6): > A tools/libxl: Make libxl__conversion_helper_abort() safe to use > M docs/libxl: Re-specify XENSTORE_DATA as EMULATOR_XENSTORE_DATA > M tools/libxl: Save and restore EMULATOR_XENSTORE_DATA content I acked these two and applied, thanks! (I don't recall if I saw a formal release-ack for these, but it's on the blocker list so I didn't bother looking...)