All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	xen-devel@lists.xenproject.org,
	Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [PATCH] osstest: install libnl3 packages
Date: Wed, 5 Aug 2015 11:51:19 +0100	[thread overview]
Message-ID: <1438771879.9747.58.camel@citrix.com> (raw)
In-Reply-To: <21909.22565.51390.310067@mariner.uk.xensource.com>

On Thu, 2015-07-02 at 16:26 +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH] osstest: install libnl3 packages"):
> > Install the libnl3 packages needed by the remus code. Those are 
> > available on
> > both Wheezy and Jessie, although the Wheezy ones are too old.
> 
> This patch implicitly drops support for lenny and squeeze.  I think
> you should mention that in the commit message.

I added your "This patch...squeeze." sentence to the commit message, acked
it and pushed to pretest.

There was a conflict with the addition of ebtables, the result is below.

commit 2ff90f75e5b40152998b69900adf1985382409bf
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Jul 1 17:12:25 2015 +0200

    osstest: install libnl3 packages
    
    Install the libnl3 packages needed by the remus code. Those are available on
    both Wheezy and Jessie, although the Wheezy ones are too old.
    
    This patch implicitly drops support for lenny and squeeze.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Ian Campbell <ian.campbell@citrix.com>
    Cc: Ian Jackson <ian.jackson@eu.citrix.com>
    Cc: Ian Campbell <ian.campbell@citrix.com>
    Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>
    Cc: Yang Hongyang <yanghy@cn.fujitsu.com>
    [ ijc -- resolved conflict with addition of ebtables ]

diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index 03ad35c..ace8080 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -206,14 +206,9 @@ sub prep () {
                       autoconf automake libtool xsltproc
                       libxml2-utils libxml2-dev
                       libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
-                      ccache nasm checkpolicy ebtables);
+                      ccache nasm checkpolicy ebtalbes
+                      libnl-3-dev libnl-route-3-dev);
 
-    if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {
-	push(@packages, "libnl-dev");
-    } else {
-	# jessie (>jessie?)
-	push(@packages, "libnl-route-3-dev");
-    }
     target_install_packages($ho, @packages);
     target_cmd_root($ho, "chmod -R a+r /usr/share/git-core/templates");
     # workaround for Debian #595728

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-08-05 10:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 15:12 [PATCH] osstest: install libnl3 packages Roger Pau Monne
2015-07-02  3:20 ` Yang Hongyang
2015-07-02 15:26 ` Ian Jackson
2015-08-05 10:51   ` Ian Campbell [this message]
2015-08-05 11:54     ` Ian Campbell
2015-08-05 16:08       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438771879.9747.58.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.