From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST] libvirt: Pass correct arguments to
	virsh migrate
Date: Wed, 5 Aug 2015 13:47:31 +0100
Message-ID: <1438778851.9747.83.camel@citrix.com>
References: <1438778539-24804-1-git-send-email-ian.campbell@citrix.com>
	<20150805124357.GK26074@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150805124357.GK26074@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-08-05 at 13:43 +0100, Wei Liu wrote:
> On Wed, Aug 05, 2015 at 01:42:19PM +0100, Ian Campbell wrote:
> > $dst is a host hash/object, resulting in:
> > 
> > 2015-08-04 22:35:25 Z executing ssh ... root@172.16.144.34 virsh
> > migrate debian.guest.osstest HASH(0x28f4310)
> > bash: -c: line 0: syntax error near unexpected token `('
> > bash: -c: line 0: `virsh migrate debian.guest.osstest HASH(0x28f4310)'
> > 
> > Switch to using the same pattern as xl.pm, which is to call the
> > argument (containing the host hash) $dho and for $dst to be a local
> > variable containing $dho->{Name}.
> > 
> > Also s/$ho/$sho/ to match xl.pm, since I think that is clearer about
> > what role everything has.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > ---
> >  Osstest/Toolstack/libvirt.pm | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Osstest/Toolstack/libvirt.pm 
> > b/Osstest/Toolstack/libvirt.pm
> > index 32dca84..e2d646c 100644
> > --- a/Osstest/Toolstack/libvirt.pm
> > +++ b/Osstest/Toolstack/libvirt.pm
> > @@ -104,10 +104,11 @@ sub saverestore_check ($) {
> >  }
> >  
> >  sub migrate ($) {
> 
> sub migrate ($$$$) ?

I think so, I wonder why Perl wasn't complaining about that...

I'll respin.

> 
> > -    my ($self,$gho,$dst,$timeout) = @_;
> > -    my $ho = $self->{Host};
> > +    my ($self,$gho,$dho,$timeout) = @_;
> > +    my $sho = $self->{Host};
> > +    my $dst = $dho->{Name};
> >      my $gn = $gho->{Name};
> > -    target_cmd_root($ho, "virsh migrate $gn $dst", $timeout);
> > +    target_cmd_root($sho, "virsh migrate $gn $dst", $timeout);
> >  }
> >  
> >  sub save ($$$$) {