From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v2] libvirt: Pass correct arguments to virsh migrate Date: Wed, 5 Aug 2015 13:55:38 +0100 Message-ID: <1438779338.9747.85.camel@citrix.com> References: <1438778907-28404-1-git-send-email-ian.campbell@citrix.com> <20150805124935.GL26074@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150805124935.GL26074@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-08-05 at 13:49 +0100, Wei Liu wrote: > On Wed, Aug 05, 2015 at 01:48:27PM +0100, Ian Campbell wrote: > > $dst is a host hash/object, resulting in: > > > > 2015-08-04 22:35:25 Z executing ssh ... root@172.16.144.34 virsh > > migrate debian.guest.osstest HASH(0x28f4310) > > bash: -c: line 0: syntax error near unexpected token `(' > > bash: -c: line 0: `virsh migrate debian.guest.osstest HASH(0x28f4310)' > > > > Switch to using the same pattern as xl.pm, which is to call the > > argument (containing the host hash) $dho and for $dst to be a local > > variable containing $dho->{Name}. > > > > Also s/$ho/$sho/ to match xl.pm, since I think that is clearer about > > what role everything has. > > > > Fix the prototype too while editing this function. > > > > Signed-off-by: Ian Campbell > > Acked-by: Wei Liu > > Thanks for the fix! NP. I've pushed this to pretest and killed flight 60606 which hadn't alloca ted any hosts yet. Ian.