* [PATCH] gpio: omap: Fix missing raw locks conversion
@ 2015-08-05 14:37 Axel Lin
2015-08-13 12:44 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-08-05 14:37 UTC (permalink / raw)
To: Linus Walleij
Cc: Sebastian Andrzej Siewior, Javier Martinez Canillas,
Santosh Shilimkar, Kevin Hilman, Alexandre Courbot, linux-omap,
linux-gpio
Fix below build warning:
CC drivers/gpio/gpio-omap.o
drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_type':
drivers/gpio/gpio-omap.c:504:3: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default]
include/linux/spinlock.h:360:29: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
Fixes: commit 4dbada2be460 ("gpio: omap: use raw locks for locking")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index dba67b2..466fe70 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -501,7 +501,7 @@ static int omap_gpio_irq_type(struct irq_data *d, unsigned type)
raw_spin_lock_irqsave(&bank->lock, flags);
retval = omap_set_gpio_triggering(bank, offset, type);
if (retval) {
- spin_unlock_irqrestore(&bank->lock, flags);
+ raw_spin_unlock_irqrestore(&bank->lock, flags);
goto error;
}
omap_gpio_init_irq(bank, offset);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: omap: Fix missing raw locks conversion
2015-08-05 14:37 [PATCH] gpio: omap: Fix missing raw locks conversion Axel Lin
@ 2015-08-13 12:44 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-08-13 12:44 UTC (permalink / raw)
To: Axel Lin
Cc: Sebastian Andrzej Siewior, Javier Martinez Canillas,
Santosh Shilimkar, Kevin Hilman, Alexandre Courbot, Linux-OMAP,
linux-gpio@vger.kernel.org
On Wed, Aug 5, 2015 at 4:37 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Fix below build warning:
> CC drivers/gpio/gpio-omap.o
> drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_type':
> drivers/gpio/gpio-omap.c:504:3: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default]
> include/linux/spinlock.h:360:29: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
>
> Fixes: commit 4dbada2be460 ("gpio: omap: use raw locks for locking")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Fixed by merging in -rc4 and applying this patch for next.
Thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-13 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-05 14:37 [PATCH] gpio: omap: Fix missing raw locks conversion Axel Lin
2015-08-13 12:44 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.