From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: Re: [PATCH v7 2/8] cxenstored: add support for systemd active sockets
Date: Thu, 6 Aug 2015 12:03:00 +0100 [thread overview]
Message-ID: <1438858980.9747.130.camel@citrix.com> (raw)
In-Reply-To: <20150806105619.GK15719@zion.uk.xensource.com>
On Thu, 2015-08-06 at 11:56 +0100, Wei Liu wrote:
> On Thu, Aug 06, 2015 at 11:48:15AM +0100, Ian Campbell wrote:
> > On Thu, 2015-08-06 at 11:17 +0100, Wei Liu wrote:
> > >
> > > I don't think so. Though the doc is not clear on how we should use
> > > those
> > > APIs, I got my idea from
> > >
> > > http://0pointer.de/public/cups-patch-core.txt
> > >
> > > which doesn't call sd_booted.
> >
> > OK, FM then: Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > As a future cleanup I think some of the ifdeferry could be removed by
> > having systemd = false ifndef SYSTEMD_ENABLED, what do you think?
>
> Maybe. In the end there has to be some ifdeferry some where to gate the
> implementation. As a future cleanup I think I can provide a stub
> systemd_checkin() which always returns false and remove all ifdef in
> main().
Right, that's what I meant, i.e. just reduce the amount of ifdef.
>
> Wei.
next prev parent reply other threads:[~2015-08-06 11:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 23:28 [PATCH v7 0/8] xen: add systemd support Luis R. Rodriguez
2014-07-17 23:28 ` [PATCH v7 1/8] xenstored: enable usage of config.h on both xenstored and oxenstored Luis R. Rodriguez
2014-07-17 23:28 ` [PATCH v7 2/8] cxenstored: add support for systemd active sockets Luis R. Rodriguez
2014-07-24 15:10 ` Ian Campbell
2014-07-24 15:54 ` Ian Campbell
2014-07-25 22:45 ` Luis R. Rodriguez
2014-07-28 9:48 ` Ian Campbell
2014-07-28 15:06 ` Luis R. Rodriguez
2015-08-05 10:06 ` George Dunlap
2015-08-05 10:17 ` Ian Campbell
2015-08-05 10:56 ` George Dunlap
2015-08-05 11:11 ` Ian Campbell
2015-08-05 11:14 ` Ian Campbell
2015-08-05 11:21 ` George Dunlap
2015-08-05 11:27 ` Ian Campbell
2015-08-05 13:17 ` Wei Liu
2015-08-05 16:30 ` George Dunlap
2015-08-05 17:24 ` Wei Liu
2015-08-05 18:19 ` Wei Liu
2015-08-06 9:13 ` Ian Campbell
2015-08-06 9:20 ` Wei Liu
2015-08-06 9:29 ` Ian Campbell
2015-08-06 9:36 ` Wei Liu
2015-08-06 10:17 ` Wei Liu
2015-08-06 10:48 ` Ian Campbell
2015-08-06 10:56 ` Wei Liu
2015-08-06 11:03 ` Ian Campbell [this message]
2015-08-06 13:56 ` George Dunlap
2014-07-17 23:28 ` [PATCH v7 3/8] oxenstored: " Luis R. Rodriguez
2014-07-17 23:28 ` [PATCH v7 4/8] oxenstored: force FD_CLOEXEC with Unix.set_close_on_exec on LSB init Luis R. Rodriguez
2014-07-24 15:09 ` Ian Campbell
2014-07-17 23:28 ` [PATCH v7 5/8] autoconf: xen: move standard path variables to config/Paths.mk.in Luis R. Rodriguez
2014-07-24 15:29 ` Ian Campbell
2014-07-17 23:28 ` [PATCH v7 6/8] xencommons: move module list into a generic place Luis R. Rodriguez
2014-07-24 15:35 ` Ian Campbell
2014-07-25 23:16 ` Luis R. Rodriguez
2014-07-17 23:28 ` [PATCH v7 7/8] autoconf: xen: enable explicit preference option for xenstored preference Luis R. Rodriguez
2014-07-24 15:40 ` Ian Campbell
2014-07-25 23:25 ` Luis R. Rodriguez
2014-07-17 23:28 ` [PATCH v7 8/8] systemd: add xen systemd service and module files Luis R. Rodriguez
2014-07-24 15:47 ` Ian Campbell
2014-07-25 23:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438858980.9747.130.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.