From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6] libxl: use correct command line for arm guests. Date: Thu, 6 Aug 2015 13:58:40 +0100 Message-ID: <1438865920.9747.152.camel@citrix.com> References: <1438858557-4184-1-git-send-email-ian.campbell@citrix.com> <20150806111059.GL15719@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150806111059.GL15719@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-08-06 at 12:10 +0100, Wei Liu wrote: > On Thu, Aug 06, 2015 at 11:55:57AM +0100, Ian Campbell wrote: > > We need to use libxl__domain_build_state.pv_cmdline in order to pickup > > the correct args when using pygrub. libxl_domain_build_info.cmdline is > > any args statically configured by the user. > > > > This is consistent with the call to xc_domain_allocate, which takes > > the cmdline too (in that case for x86/PV usage). > > > > state->pv_cmdline is also set for non-pygrub guests, since > > libxl_bootloader_run propagates info->cmdline if no bootloader is > > libxl__bootloader_run Fixed. > > condfigured. ... and this. > > > > Signed-off-by: Ian Campbell > > Acked-by: Wei Liu Thanks. > > > --- > > For 4.6: This makes pygrub work on ARM. > > > > It's very low risk. Apply as you see fit. Done, thanks.