From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 3/5] cxenstored: remove dead option
Date: Thu, 6 Aug 2015 14:49:28 +0100 [thread overview]
Message-ID: <1438868968.9747.157.camel@citrix.com> (raw)
In-Reply-To: <1438868305-30920-4-git-send-email-wei.liu2@citrix.com>
On Thu, 2015-08-06 at 14:38 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> For 4.6: remove dead code, risk free.
I'm pretty sure this isn't actually dead:
The 'm' option is handled by option parsing, setting the dom0_domid global.
xenbus_master_domid() returns dom0_domid and that is called by both
dom0_init() and, for mini-os, xenbus_map().
So I think this is used by stub-xenstored somehow.
At the least we shouldn't remove the option without also removing all the
above, and that is not 4.6 material at this point IMHO.
Ian.
next prev parent reply other threads:[~2015-08-06 13:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 13:38 [PATCH for-4.6 0/5] Patches for c/oxenstored Wei Liu
2015-08-06 13:38 ` [PATCH for-4.6 1/5] cxenstored: fix systemd socket activation Wei Liu
2015-08-06 13:38 ` [PATCH for-4.6 2/5] cxenstored: document a bunch of short options in help string Wei Liu
2015-08-06 15:54 ` Ian Campbell
2015-08-06 13:38 ` [PATCH for-4.6 3/5] cxenstored: remove dead option Wei Liu
2015-08-06 13:49 ` Ian Campbell [this message]
2015-08-06 13:52 ` Wei Liu
2015-08-06 13:38 ` [PATCH for-4.6 4/5] oxenstored: fix systemd socket activation Wei Liu
2015-08-06 13:50 ` Ian Campbell
2015-08-06 16:02 ` Ian Campbell
2015-08-06 15:58 ` Dave Scott
2015-08-06 13:38 ` [PATCH for-4.6 5/5] oxenstored: move sd_notify_ready out of main loop Wei Liu
2015-08-06 16:00 ` Dave Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438868968.9747.157.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.