From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 3/5] cxenstored: remove dead option Date: Thu, 6 Aug 2015 14:49:28 +0100 Message-ID: <1438868968.9747.157.camel@citrix.com> References: <1438868305-30920-1-git-send-email-wei.liu2@citrix.com> <1438868305-30920-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZNLYC-00082U-Oo for xen-devel@lists.xenproject.org; Thu, 06 Aug 2015 13:49:40 +0000 In-Reply-To: <1438868305-30920-4-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: George Dunlap , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Thu, 2015-08-06 at 14:38 +0100, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > For 4.6: remove dead code, risk free. I'm pretty sure this isn't actually dead: The 'm' option is handled by option parsing, setting the dom0_domid global. xenbus_master_domid() returns dom0_domid and that is called by both dom0_init() and, for mini-os, xenbus_map(). So I think this is used by stub-xenstored somehow. At the least we shouldn't remove the option without also removing all the above, and that is not 4.6 material at this point IMHO. Ian.