From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Dave Scott <dave.scott@eu.citrix.com>
Subject: Re: [PATCH for-4.6 4/5] oxenstored: fix systemd socket activation
Date: Thu, 6 Aug 2015 17:02:31 +0100 [thread overview]
Message-ID: <1438876951.9747.178.camel@citrix.com> (raw)
In-Reply-To: <1438869044.9747.158.camel@citrix.com>
On Thu, 2015-08-06 at 14:50 +0100, Ian Campbell wrote:
> On Thu, 2015-08-06 at 14:38 +0100, Wei Liu wrote:
> > Use the correct API sd_listen_fds to determine whether the process is
> > started by systemd.
> >
> > Change sd_booted to booted_by_systemd to avoid confusion with systemd's
> > API.
>
> launched_by_systemd seems like a more conventional name for this.One
> doesn't typically "boot" a process.
Apart from the name the code itself looks correct to me though, so with a
name change to either launch_by_systemd or maybe have_sd_sockets or
something like that then:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-08-06 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 13:38 [PATCH for-4.6 0/5] Patches for c/oxenstored Wei Liu
2015-08-06 13:38 ` [PATCH for-4.6 1/5] cxenstored: fix systemd socket activation Wei Liu
2015-08-06 13:38 ` [PATCH for-4.6 2/5] cxenstored: document a bunch of short options in help string Wei Liu
2015-08-06 15:54 ` Ian Campbell
2015-08-06 13:38 ` [PATCH for-4.6 3/5] cxenstored: remove dead option Wei Liu
2015-08-06 13:49 ` Ian Campbell
2015-08-06 13:52 ` Wei Liu
2015-08-06 13:38 ` [PATCH for-4.6 4/5] oxenstored: fix systemd socket activation Wei Liu
2015-08-06 13:50 ` Ian Campbell
2015-08-06 16:02 ` Ian Campbell [this message]
2015-08-06 15:58 ` Dave Scott
2015-08-06 13:38 ` [PATCH for-4.6 5/5] oxenstored: move sd_notify_ready out of main loop Wei Liu
2015-08-06 16:00 ` Dave Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438876951.9747.178.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dave.scott@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.