From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 4/5] oxenstored: fix systemd socket activation Date: Thu, 6 Aug 2015 17:02:31 +0100 Message-ID: <1438876951.9747.178.camel@citrix.com> References: <1438868305-30920-1-git-send-email-wei.liu2@citrix.com> <1438868305-30920-5-git-send-email-wei.liu2@citrix.com> <1438869044.9747.158.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZNNpK-0000v7-4V for xen-devel@lists.xenproject.org; Thu, 06 Aug 2015 16:15:30 +0000 In-Reply-To: <1438869044.9747.158.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: George Dunlap , Ian Jackson , Dave Scott List-Id: xen-devel@lists.xenproject.org On Thu, 2015-08-06 at 14:50 +0100, Ian Campbell wrote: > On Thu, 2015-08-06 at 14:38 +0100, Wei Liu wrote: > > Use the correct API sd_listen_fds to determine whether the process is > > started by systemd. > > > > Change sd_booted to booted_by_systemd to avoid confusion with systemd's > > API. > > launched_by_systemd seems like a more conventional name for this.One > doesn't typically "boot" a process. Apart from the name the code itself looks correct to me though, so with a name change to either launch_by_systemd or maybe have_sd_sockets or something like that then: Acked-by: Ian Campbell