Re: [PATCH v4] ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs

[Artem Bityutskiy <dedekind1@gmail.com>]

Could you please describe how you tested your patch. Did you run stress
tests with atime enabled, which ones?

On Fri, 2015-07-31 at 09:09 +0800, Dongsheng Yang wrote:
> +> 	> 	> sb->s_flags |= MS_ACTIVE;
> +#ifndef CONFIG_UBIFS_ATIME_SUPPORT
> +> 	> 	> sb->s_flags |= MS_NOATIME;
> +#else
> +> 	> 	> ubifs_warn(c, "************WARNING START****************");
> +> 	> 	> ubifs_warn(c, "Ubifs is supporting atime now, that would");
> +> 	> 	> ubifs_warn(c, "probably damage your flash. If you are not");
> +> 	> 	> ubifs_warn(c, "sure about it, please set UBIFS_ATIME_SUPPORT");
> +> 	> 	> ubifs_warn(c, "to 'N'.");
> +> 	> 	> ubifs_warn(c, "************WARNING END******************");

Could we please be a little be less scary.

1. I think these starting and ending "*****" lines are unnecessary.
2. Ah, and use "UBIFS", not "Ubifs" please.
3. Let's be shorter, just this should be enough:

ubifs_warn("full atime support is enabled, which may wear out your
flash faster");

Artem.