All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mengdong Lin <mengdong.lin@intel.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 3/3] topology: A API calls to directly build	topology data from templates
Date: Tue, 11 Aug 2015 09:04:48 +0100	[thread overview]
Message-ID: <1439280288.2427.5.camel@loki> (raw)
In-Reply-To: <s5htws62r6d.wl-tiwai@suse.de>

On Tue, 2015-08-11 at 09:57 +0200, Takashi Iwai wrote:
> > @@ -34,6 +34,10 @@
> >  #define ALSA_TPLG_DIR        ALSA_CONFIG_DIR "/topology"
> >  #define ARRAY_SIZE(x) (sizeof(x) / sizeof(x[0]))
> >  
> > +#define container_of(ptr, type, member) ({                      \
> > +      const typeof( ((type *)0)->member ) *__mptr = (ptr);    \
> > +     (type *)( (char *)__mptr - offsetof(type,member) );})
> 
> This is a pretty common macro, so I prefer having it in
> include/local.h.

I'll also move ARRAY_SIZE() to local.h too since it's common.

Liam

  reply	other threads:[~2015-08-11  8:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 18:13 [PATCH v2 0/3] topology: Add external API for building topology data Liam Girdwood
2015-08-10 18:13 ` [PATCH v2 1/3] topology: rename OBJECT_TYPE_ to SND_TPLG_TYPE_ Liam Girdwood
2015-08-10 18:13 ` [PATCH v2 2/3] topology: Add C templates structure for building topology from C programs Liam Girdwood
2015-08-10 18:13 ` [PATCH v2 3/3] topology: A API calls to directly build topology data from templates Liam Girdwood
2015-08-11  7:57   ` Takashi Iwai
2015-08-11  8:04     ` Liam Girdwood [this message]
2015-08-11  8:18       ` Takashi Iwai
2015-08-11 12:36     ` Liam Girdwood
2015-08-11 15:37     ` Lin, Mengdong
2015-08-11 15:55       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439280288.2427.5.camel@loki \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=mengdong.lin@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.