From: Joe Perches <joe@perches.com>
To: Javi Merino <javi.merino@arm.com>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.cz>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: check Signed-off-by: lines for patches coming from stdin
Date: Tue, 11 Aug 2015 09:47:49 -0700 [thread overview]
Message-ID: <1439311669.3244.14.camel@perches.com> (raw)
In-Reply-To: <1439302814-5750-1-git-send-email-javi.merino@arm.com>
On Tue, 2015-08-11 at 15:20 +0100, Javi Merino wrote:
> Commit 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe
> to show filenames") disabled the ability to check for Signed-off-by
> lines in patches that are fed to scripts/checkpatch.pl from stdin. This
> makes things like:
>
> git rebase --interactive --exec 'git format-patch --stdout -1 | scripts/checkpatch.pl --strict -'
This is akin to running checkpatch on patches to the stable tree.
Generally unnecessary.
I think patches should never be committed without a sign-off so
the concept of using checkpatch when rebasing is fundamentally
odd, but <shrug>, different workflows for different folks.
You should add a "Reference: http://xkcd.com/1172/" line to the
commit message.
next prev parent reply other threads:[~2015-08-11 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 14:20 [PATCH] checkpatch: check Signed-off-by: lines for patches coming from stdin Javi Merino
2015-08-11 16:47 ` Joe Perches [this message]
2015-08-11 17:04 ` Javi Merino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439311669.3244.14.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.