From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST] Toolstack/libvirt: use URI in
 migration command
Date: Wed, 12 Aug 2015 11:05:59 +0100
Message-ID: <1439373959.9747.331.camel@citrix.com>
References: <1439324709-16828-1-git-send-email-wei.liu2@citrix.com>
	<55CA7216.7060708@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=65993c9f7=Ian.Campbell@citrix.com>)
	id 1ZPSv5-0002T6-P9
	for xen-devel@lists.xenproject.org; Wed, 12 Aug 2015 10:06:03 +0000
In-Reply-To: <55CA7216.7060708@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jim Fehlig <jfehlig@suse.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-08-11 at 16:07 -0600, Jim Fehlig wrote:
> Wei Liu wrote:
> > Virsh migrate expects an URI, not a host. We don't actually care what
> > kind of transport it uses, the main objective is to test migration, so
> > use xen+ssh for the time being.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> > Cc: Jim Fehlig <jfehlig@suse.com>
> > 
> > I once had email exchange with Jim and he said xen+ssh was a commonly
> > use configuration.
> > 
> > Jim, I hope I got the URI right. The constructed command will be like
> > 
> >    virsh migrate guest xen+ssh://dst-host
> >   
> 
> Yes, that is correct. Note you will need a '--live' option if live
> migration is what you are after
> 
>   virsh migrate --live guest xen+ssh://dst-host

I think we probably do want live (xl does it by default).

I suggest we also do
    my $duri = "xen+ssh://$dst";
else the line is probably going to get a bit long.

So I propose to fold in this:

diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
index 477ebee..776432d 100644
--- a/Osstest/Toolstack/libvirt.pm
+++ b/Osstest/Toolstack/libvirt.pm
@@ -108,7 +108,8 @@ sub migrate ($$$$) {
     my $sho = $self->{Host};
     my $dst = $dho->{Name};
     my $gn = $gho->{Name};
-    target_cmd_root($sho, "virsh migrate $gn xen+ssh://$dst", $timeout);
+    my $duri = "xen+ssh://$dst";
+    target_cmd_root($sho, "virsh migrate --live $gn $duri", $timeout);
 }
 
 sub save ($$$$) {

Ian.