From: Oliver Neukum <oneukum@suse.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/usb: Delete XHCI command timer if necessary
Date: Wed, 12 Aug 2015 15:08:41 +0200 [thread overview]
Message-ID: <1439384921.22258.3.camel@suse.com> (raw)
In-Reply-To: <55CB2626.3060000@linux.intel.com>
On Wed, 2015-08-12 at 13:55 +0300, Mathias Nyman wrote:
> Fortunately this can only happen in cases where xhci is already hosed
> (no command response for 5 seconds), and we are at the same time
> anyway about to remove xhci.
>
> Doesn't this mean that all cases with
> if (timer_pending(&timer))
> del_timer_sync(&timer)
>
> is just basically the same as a plain del_timer(&timer)?
Yes. I never understood the idiom.
> Anyways, turns out that the error path in xhci initialization code can end up calling
> del_timer_sync() before timer is initialized. This should be fixed by re-arranging
> some code in xhci initialization instead.
Good.
> Greg, should this be reverted in rc7?
> I think that the possible side effect of this patch is still lesser the original
> issue.
I agree.
Regards
Oliver
next prev parent reply other threads:[~2015-08-12 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438607269-8977-1-git-send-email-mathias.nyman@linux.intel.com>
2015-08-03 13:07 ` [PATCH 1/2] xhci: fix off by one error in TRB DMA address boundary check Mathias Nyman
2015-08-03 13:07 ` [PATCH 2/2] drivers/usb: Delete XHCI command timer if necessary Mathias Nyman
2015-08-11 8:15 ` Oliver Neukum
2015-08-12 10:55 ` Mathias Nyman
2015-08-12 13:08 ` Oliver Neukum [this message]
2015-08-12 16:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439384921.22258.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.