From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH for-4.6] tools/libxc: linux: Don't use getpagesize() when unmapping the grants
Date: Thu, 13 Aug 2015 11:31:34 +0100 [thread overview]
Message-ID: <1439461894.23981.68.camel@citrix.com> (raw)
In-Reply-To: <1439297334.9747.238.camel@citrix.com>
On Tue, 2015-08-11 at 13:48 +0100, Ian Campbell wrote:
> On Fri, 2015-08-07 at 22:45 +0100, Wei Liu wrote:
> > On Fri, Aug 07, 2015 at 07:53:55PM +0100, Julien Grall wrote:
> > > The grants are based on the Xen granularity (i.e 4KB). While the
> > > function
> > > to map grants for Linux (linux_gnttab_grant_map) is using the correct
> > > size (XC_PAGE_SIZE), the unmap one (linux_gnttab_munmap) is using
> > > getpagesize().
> > >
> > > On domain using a page granularity different than Xen (this is the
> > > case
> > > for AARCH64 guest using 64KB page), the unmap will be called with the
> > > wrong size.
> > >
> > > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > >
> > > ---
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Wei Liu <wei.liu2@citrix.com>
> > >
> >
> > Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> > I think this is a bug fix and should be applied for 4.6.
I took this as a release ack and applied.
prev parent reply other threads:[~2015-08-13 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 18:53 [PATCH for-4.6] tools/libxc: linux: Don't use getpagesize() when unmapping the grants Julien Grall
2015-08-07 21:45 ` Wei Liu
2015-08-11 12:48 ` Ian Campbell
2015-08-12 10:07 ` Julien Grall
2015-08-13 10:31 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439461894.23981.68.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.