From: Johannes Berg <johannes@sipsolutions.net>
To: amit.khatri@samsung.com
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Rahul Jain <rahul.jain@samsung.com>,
HEMANSHU SRIVASTAVA <hemanshu.s@samsung.com>,
Nitin Jhanwar <nitin.j@samsung.com>
Subject: Re: [PATCH 3/3] iw: Avoid possible memory leak for cb
Date: Thu, 13 Aug 2015 15:22:09 +0200 [thread overview]
Message-ID: <1439472129.2114.32.camel@sipsolutions.net> (raw)
In-Reply-To: <1629204510.56471439461785277.JavaMail.weblogic@ep2mlwas02d>
This patch doesn't look correct - in the case that 'cb' fails to
allocate, the existing code is actually correct. In the case that s_cb
fails to allocate, it's clearly incorrect, but that means the two
conditions need to be disentangled, no?
Also, I've applied the other two patches despite them being severely
mangled - please try to improve your submission process so the patches
can apply - perhaps send them to yourself and see if 'git am' can
handle them to figure out what's wrong.
johannes
prev parent reply other threads:[~2015-08-13 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 10:29 [PATCH 3/3] iw: Avoid possible memory leak for cb Amit Khatri
2015-08-13 13:22 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439472129.2114.32.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amit.khatri@samsung.com \
--cc=hemanshu.s@samsung.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nitin.j@samsung.com \
--cc=rahul.jain@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.