All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 v2 3/3] libxc: fix vNUMA memory allocation
Date: Sun, 16 Aug 2015 09:47:15 +0100	[thread overview]
Message-ID: <1439714835.3480.10.camel@citrix.com> (raw)
In-Reply-To: <1439480480-20939-4-git-send-email-wei.liu2@citrix.com>

On Thu, 2015-08-13 at 16:41 +0100, Wei Liu wrote:
> We should use new_memflags in xc_domain_populate_physmap. That 
> variable
> contains node information.

Same question as v1.

> 
> Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
>  tools/libxc/xc_hvm_build_x86.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxc/xc_hvm_build_x86.c 
> b/tools/libxc/xc_hvm_build_x86.c
> index ec11f15..ea250dd 100644
> --- a/tools/libxc/xc_hvm_build_x86.c
> +++ b/tools/libxc/xc_hvm_build_x86.c
> @@ -486,7 +486,8 @@ static int setup_guest(xc_interface *xch,
>  
>                  done = xc_domain_populate_physmap(xch, dom, 
> nr_extents,
>                                                   
>  SUPERPAGE_1GB_SHIFT,
> -                                                  memflags, 
> sp_extents);
> +                                                  new_memflags,
> +                                                  sp_extents);
>  
>                  if ( done > 0 )
>                  {
> @@ -526,7 +527,8 @@ static int setup_guest(xc_interface *xch,
>  
>                      done = xc_domain_populate_physmap(xch, dom, 
> nr_extents,
>                                                       
>  SUPERPAGE_2MB_SHIFT,
> -                                                      memflags, 
> sp_extents);
> +                                                      new_memflags,
> +                                                      sp_extents);
>  
>                      if ( done > 0 )
>                      {

  reply	other threads:[~2015-08-16  8:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 15:41 [PATCH for-4.6 v2 0/3] More vNUMA fixes Wei Liu
2015-08-13 15:41 ` [PATCH for-4.6 v2 1/3] xl: fix vNUMA vdistance parsing Wei Liu
2015-08-16  8:46   ` Ian Campbell
2015-08-13 15:41 ` [PATCH for-4.6 v2 2/3] xl: error out if vNUMA specifies more vcpus than pcpus Wei Liu
2015-08-13 23:25   ` Dario Faggioli
2015-08-13 23:38     ` Wei Liu
2015-08-14 10:19       ` Dario Faggioli
2015-08-16  8:51       ` Ian Campbell
2015-08-17 18:42         ` Wei Liu
2015-08-13 15:41 ` [PATCH for-4.6 v2 3/3] libxc: fix vNUMA memory allocation Wei Liu
2015-08-16  8:47   ` Ian Campbell [this message]
2015-08-14 15:19 ` Empty memory nodes in VNUMA Boris Ostrovsky
2015-08-14 15:35   ` Wei Liu
2015-08-14 15:38     ` Boris Ostrovsky
2015-08-14 15:44       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439714835.3480.10.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.