From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: OSSTest RFC: ts-xen-build-prep, lvextend1(),
 don't call lvextend if "-l 0"
Date: Sun, 16 Aug 2015 10:05:24 +0100
Message-ID: <1439715924.3480.24.camel@citrix.com>
References: <9E79D1C9A97CFD4097BCE431828FDD31DB0A68@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <9E79D1C9A97CFD4097BCE431828FDD31DB0A68@SHSMSX103.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Hu, Robert" <robert.hu@intel.com>, 'Ian Jackson' <Ian.Jackson@eu.citrix.com>, "'wei.liu2@citrix.com'" <wei.liu2@citrix.com>
Cc: "'xen-devel@lists.xen.org'" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-08-14 at 03:54 +0000, Hu, Robert wrote:
> Hi,
> 
> lvextend will report error if doing with "-l 0".
> So I propose to add an judgment regarding $vg_more_free_pe.
> 
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index 9a3b523..f1d1255 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -155,7 +155,8 @@ sub lvextend1 ($$$) {
>          logm("$what: unstriped $vg_more_free_pe PEs");
>          overall_limit_pe(\$vg_more_free_pe);
>          $more_pe += $vg_more_free_pe;
> -        target_cmd_root($ho, "lvextend -i1 -l +$vg_more_free_pe $lv");
> +        target_cmd_root($ho, "lvextend -i1 -l +$vg_more_free_pe $lv") 
> +               if $vg_more_free_pe != 0;
>      }

In my tree at least the } is closing a "if ($vg_more_free_pe)". Perhaps
it would make more sense to extend that to also check for ? 0?

if (($vg_more_free_pe//0) > 0)

is probably nicer than
if ($vg_more_free_pe && $vg_more_free_pe > 0)
I suppose.

Or maybe add //0 to the 
    my $vg_more_free_pe= $vginfo[15];

Ian.