All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Chandler Paul <cpaul@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Nick Bowler <nbowler@draconx.ca>,
	linux-input <linux-input@vger.kernel.org>,
	Andrew Duggan <andrew.duggan@gmail.com>
Subject: Re: PROBLEM: Missing events on thinkpad trackpoint buttons
Date: Wed, 19 Aug 2015 17:33:27 -0400	[thread overview]
Message-ID: <1440020007.14257.4.camel@redhat.com> (raw)
In-Reply-To: <20150819212748.GB19499@dtor-pixel>

There is support in the spec for PS/2 guests believe it or not, it's
just mostly undocumented. Coincidentally, I was actually the one who
wrote the drivers for this in Benjamin's tree. Using that, we can
actually just create a serio port that goes through the rmi4 driver and
communicate with that using the normal TrackPoint driver. We have a
working implementation of this here: 
https://github.com/bentiss/linux/tree/synaptics-rmi4-smbus-v4.2-rc6%2B

Cheers,
	Stephen Chandler Paul

On Wed, 2015-08-19 at 14:27 -0700, Dmitry Torokhov wrote:
> On Wed, Aug 19, 2015 at 09:52:00AM -0400, Benjamin Tissoires wrote:
> > On Tue, Aug 18, 2015 at 3:06 PM, Benjamin Tissoires
> > <benjamin.tissoires@gmail.com> wrote:
> > > Hi Nick,
> > > 
> > > thanks for the report.
> > > 
> > > On Mon, Aug 17, 2015 at 10:31 PM, Nick Bowler <nbowler@draconx.ca
> > > > wrote:
> > > > Hi,
> > > > 
> > > > I'm not sure if this is actually a Linux issue but figured I'd
> > > > at least
> > > > report it here to start...
> > > > 
> > > > I have a Lenovo Thinkpad X250, with the newfangled trackpoint
> > > > buttons.
> > > > I have a problem with missing button press or release events:
> > > > sometimes
> > > > pressing a button has no effect, and sometimes releasing a
> > > > button has no
> > > > effect (the latter is especially annoying, as the button
> > > > remains depressed
> > > > as far as any applications are concerned).
> > > > 
> > > > After some testing, the problem apparently depends on the
> > > > position of my
> > > > hands over the touchpad.  I can reliably reproduce it as
> > > > follows: place
> > > > two fingers on the touchpad, then press the button repeatedly. 
> > > >  Watching
> > > > with evtest, several events (could be either press or release)
> > > > will
> > > > simply be missin, although the kernel never does anything weird
> > > > like
> > > > send two release events in a row.  There are no problems if
> > > > there are
> > > > 0 or 1 fingers on the touchpad.
> > > > 
> > > > My current kernel version is 4.1.6, although the problem occurs
> > > > in all
> > > > versions that I tried.
> > > > 
> > > > Here is the evtest result from placing two fingers on the
> > > > touchpad, then
> > > > pressing the left trackpoint button 10 times, counting 1 second
> > > > between
> > > > each press.  As you can see, only 3 presses and 3 release
> > > > events total
> > > > were sent by the kernel, sometimes with many physical button
> > > > presses
> > > > between the press and its corresponding release:
> > > 
> > > OK, so this is definitively weird. My first idea would be a
> > > firmware
> > > problem. I have asked Chandler to reproduce it on his t450 and
> > > see if
> > > we observe it on our laptops too.
> > 
> > Update on this one : Chandler reproduced it on the t450, so it's
> > likely that all of these sensors are affected. It is still unclear
> > if
> > it is a firmware bug or a driver problem, but the chances are huge
> > that this is a firmware bug. Anyway, that's one more reason to push
> > towards RMI4 over SMBus for these sensors: the bug is not present
> > with
> > this protocol :)
> 
> By the way, how are we going to handle Trackpoint (PS/2 device) with
> touchpads in RMI4 mode? I do not recall anything in RMI4 spec, but I
> looked at it quite some time ago.
> 
> Thanks.
> 

  reply	other threads:[~2015-08-19 21:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  2:31 PROBLEM: Missing events on thinkpad trackpoint buttons Nick Bowler
2015-08-18 19:06 ` Benjamin Tissoires
2015-08-19 13:52   ` Benjamin Tissoires
2015-08-19 14:10     ` Nick Bowler
2015-08-19 14:12       ` Benjamin Tissoires
2015-08-19 21:27     ` Dmitry Torokhov
2015-08-19 21:33       ` Stephen Chandler Paul [this message]
2015-08-19 21:34       ` Benjamin Tissoires
  -- strict thread matches above, loose matches on Subject: below --
2015-08-20 20:50 Gabor Balla
2015-08-20 21:35 ` Dmitry Torokhov
2015-08-20 22:24   ` Gabor Balla
2015-08-20 22:42     ` Gabor Balla
2015-08-20 22:56     ` Dmitry Torokhov
2015-08-20 23:01       ` Dmitry Torokhov
2015-08-20 23:05         ` Gabor Balla
2015-08-20 23:08           ` Dmitry Torokhov
2015-08-20 23:13             ` Dmitry Torokhov
2015-08-20 23:35               ` Gabor Balla
2015-08-21  0:06                 ` Dmitry Torokhov
2015-08-24 17:57               ` Dmitry Torokhov
2015-08-24 23:44                 ` Nick Bowler
     [not found]               ` <CAN+gG=H88uVbRun=Vs1r1b8jM=wpnC1285BquFpDsh8HQdr07Q@mail.gmail.com>
2015-09-27 12:14                 ` Benjamin Tissoires
2015-09-28 22:52                   ` Dmitry Torokhov
2015-09-29  0:22                     ` Nick Bowler
2015-09-29  0:26                       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440020007.14257.4.camel@redhat.com \
    --to=cpaul@redhat.com \
    --cc=andrew.duggan@gmail.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=nbowler@draconx.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.