All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] audio: multi channel audio support
Date: Thu, 20 Aug 2015 01:46:43 +0200	[thread overview]
Message-ID: <1440028003.28369.11.camel@redhat.com> (raw)
In-Reply-To: <cover.1439821260.git.DirtY.iCE.hu@gmail.com>

  Hi,

> Currently you have to specify the number of channels you want to use
> when creating the usb-audio device, see the last commit for details.
> To do this I currently dynamically allocate the whole USBDesc structure,
> which looks ugly.  If there's a better way, please let me know!

You can have multiple USBDesc stuctures defined and pick one at device
initialization time (see hw/usb/dev-hid.c, there are usb 1.1 and usb 2.0
versions of all hid devices).

For usb-audio I think we need two: the current one (stereo) and a new
one with stereo + 5.1 and 7.1 support.  Then for the new one have 4
alternative interface configurations (off, stereo, 5.1, 7.1) instead of
only two (off, stereo).  Or possibly we need 3 interfaces (stereo, 5.1,
7.1) with on and off alternatives for each of them.  Didn't check
usb-audio spec.

cheers,
  Gerd

      parent reply	other threads:[~2015-08-19 23:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 16:41 [Qemu-devel] [PATCH 0/5] audio: multi channel audio support Kővágó, Zoltán
2015-08-17 16:55 ` [Qemu-devel] [PATCH 2/5] audio: basic support for multichannel audio Kővágó, Zoltán
2015-08-17 16:55 ` [Qemu-devel] [PATCH 3/5] paaudio: channel-map option Kővágó, Zoltán
2015-08-17 16:55 ` [Qemu-devel] [PATCH 4/5] usb-audio: do not count on avail bytes actually available Kővágó, Zoltán
2015-08-17 18:11 ` [Qemu-devel] [PATCH 5/5] usb-audio: support more than two channels of audio Kővágó, Zoltán
2015-08-17 18:12 ` [Qemu-devel] [PATCH 1/5] audio: replace shift in audio_pcm_info with bytes_per_frame Kővágó, Zoltán
2015-08-19 23:46 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440028003.28369.11.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=dirty.ice.hu@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.