From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 v3 1/3] xl: fix vNUMA vdistance parsing Date: Thu, 20 Aug 2015 10:04:58 +0100 Message-ID: <1440061498.3480.87.camel@citrix.com> References: <1439837821-8930-1-git-send-email-wei.liu2@citrix.com> <1439837821-8930-2-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZSLmR-0004mc-Qo for xen-devel@lists.xenproject.org; Thu, 20 Aug 2015 09:05:03 +0000 In-Reply-To: <1439837821-8930-2-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Dario Faggioli , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Mon, 2015-08-17 at 19:56 +0100, Wei Liu wrote: > We should parse the output from splitting function, not the original > string, otherwise the parsed result is wrong. > > For example: > > vnuma = [ [...,"vdistance=10,20",...], > [...,"vdistance=20,10",...] ] > > Before this change, vdistance from node 0 to all nodes (including > itself) was 10 and vdistance from node 1 to all nodes was 20. > > After this change, vdistance from node 0 to itself is 10, to node 1 > is > 20 and vdistance from node 1 to node 0 is 20, to itself is 10. That's > the correct vdistance settings we expect. > > Signed-off-by: Wei Liu > Reviewed-by: Dario Faggioli Acked-by: Ian Campbell