From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 v3 3/3] libxc: fix vNUMA memory allocation Date: Thu, 20 Aug 2015 10:47:13 +0100 Message-ID: <1440064033.3480.91.camel@citrix.com> References: <1439837821-8930-1-git-send-email-wei.liu2@citrix.com> <1439837821-8930-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZSMRL-0007pr-Rs for xen-devel@lists.xenproject.org; Thu, 20 Aug 2015 09:47:19 +0000 In-Reply-To: <1439837821-8930-4-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Dario Faggioli , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Mon, 2015-08-17 at 19:57 +0100, Wei Liu wrote: > Only 4KB allocation was using new_memflags. We should use > new_memflags > in for 2MB and 1GB allocation as well because that variable contains > node information. > > Without this patch, when creating a HVM guest with vNUMA, because the > node information was not present in the flags passed to libxc, actual > memory allocation didn't comply with what user specified. With this > patch the behaviour is correct. > > Reported-by: Boris Ostrovsky > Tested-by: Boris Ostrovsky > Signed-off-by: Wei Liu > Reviewed-by: Dario Faggioli Acked-by: Ian Campbell