All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Marty Faltesek <mfaltesek@google.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Michal Kazior <michal.kazior@tieto.com>
Subject: Re: mac80211: When adding a new station, notify driver before adding to hash
Date: Mon, 24 Aug 2015 14:38:32 +0200	[thread overview]
Message-ID: <1440419912.3735.16.camel@sipsolutions.net> (raw)
In-Reply-To: <CAOiWkA-rNVHiVZo5oSuEOk_o6ioPzfpd0qzw_QsekRSHQ1EeEw@mail.gmail.com> (sfid-20150821_190043_990070_A3C0773A)

On Fri, 2015-08-21 at 13:00 -0400, Marty Faltesek wrote:
> It's not IBSS and the stack is messed up, I guess because of statics.
> It's probably more likely this manually crafted stack:
> 
> __queue_work    (fails BUG_ON(!list_empty(&work->entry));) NULL work
> causes this check fail.
> queue_work_on   WORK_STRUCT_PENDING_BIT check passes cause NULL work.
> queue_work
> ieee80211_queue_work
> ath10k_sta_rc_update
> drv_sta_rc_update
> rate_control_rate_update
> ieee80211_rx_h_action
> ieee80211_rx_handlers
> ieee80211_invoke_rx_handlers
> ieee80211_prepare_and_rx_handle
> __ieee80211_rx_handle_packet
> ieee80211_rx

Ok. Still, I think the best solution would be to check sta->uploaded?

johannes

  reply	other threads:[~2015-08-24 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 21:39 mac80211: When adding a new station, notify driver before adding to hash Marty Faltesek
2015-08-21  5:04 ` Michal Kazior
2015-08-21  7:57 ` Johannes Berg
2015-08-21  7:58   ` Johannes Berg
2015-08-21 17:00     ` Marty Faltesek
2015-08-24 12:38       ` Johannes Berg [this message]
2015-08-24 16:12         ` Marty Faltesek
2015-08-24 16:15           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440419912.3735.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mfaltesek@google.com \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.