All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC PATCH 1/1] classes/whitelist: add class to allow whitelisting recipes from a layer
Date: Mon, 24 Aug 2015 16:10:28 +0200	[thread overview]
Message-ID: <1440425428.17883.3.camel@intel.com> (raw)
In-Reply-To: <1440078442.17136.60.camel@intel.com>

On Thu, 2015-08-20 at 15:47 +0200, Patrick Ohly wrote:
> One more comment: it would be slightly nicer if empty whitelist could be
> distinguished from no whitelist, with "empty" meaning "enable no
> recipes". In other words, replace "if whitelist" with "if whitelist is
> not None".
> 
> I want to list all PNWHITELIST_xxx values for meta-openembedded, even
> when the layer is not (yet) in bblayers.sample.conf, in order to be
> prepared for adding it later. Doing that with an empty string is more
> readable than with a fake recipe name to make the variable non-empty.

I'd like to retract that proposal. It's unusual to distinguish between
"set" and "set to empty string", and once set, it is (as far as I know)
impossible to unset a variable. I.e., when a distro conf enables white
listing for a layer, a user cannot undo that in local.conf.

Perhaps there should be an explicit PNWHITELIST_LAYERS variable which
lists all layers for which white listing is meant to be active, similar
to PACKAGES and FILES_<package>?

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





  parent reply	other threads:[~2015-08-24 14:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 13:34 [RFC PATCH 0/1] Add recipe whitelisting class Paul Eggleton
2015-08-19 13:34 ` [RFC PATCH 1/1] classes/whitelist: add class to allow whitelisting recipes from a layer Paul Eggleton
2015-08-20 13:47   ` Patrick Ohly
2015-08-21  7:30     ` Huang, Jie (Jackie)
2015-08-24 14:10     ` Patrick Ohly [this message]
2015-08-21 10:45   ` Richard Purdie
2015-08-21 10:52     ` Otavio Salvador
2015-08-21 11:59     ` Patrick Ohly
2015-08-21 17:45     ` Khem Raj
2015-08-21 21:43       ` Otavio Salvador
2015-08-21 22:41         ` Richard Purdie
2015-08-24 11:02     ` Paul Eggleton
2015-08-25 16:20       ` Randy MacLeod
2015-08-25 16:32         ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440425428.17883.3.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.