From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 04/16] perf ordered_events: Clear the progress bar at the end of a flush
Date: Tue, 25 Aug 2015 13:14:26 -0300 [thread overview]
Message-ID: <1440519278-623-5-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1440519278-623-1-git-send-email-acme@kernel.org>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
We were depending on the next screen operation after a flush() being
one that would redraw the whole screen so that the progress bar would
be overwritten, when that didn't happen a screen artifact of, say, a
error dialog window would be overlaid on top of the progress bar, fix
it by calling ui_browser__finish(), that now has a TUI implementation.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-el0fyw6duemnx62lydjzhs8c@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/ordered-events.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-events.c
index 52be201b9b25..b1b9e2385f4b 100644
--- a/tools/perf/util/ordered-events.c
+++ b/tools/perf/util/ordered-events.c
@@ -220,6 +220,9 @@ static int __ordered_events__flush(struct ordered_events *oe)
else if (last_ts <= limit)
oe->last = list_entry(head->prev, struct ordered_event, list);
+ if (show_progress)
+ ui_progress__finish();
+
return 0;
}
--
2.1.0
next prev parent reply other threads:[~2015-08-25 16:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 16:14 [GIT PULL 00/16] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 01/16] perf tools: Fix tarball build broken by pt/bts Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 02/16] perf annotate: Reset the dso find_symbol cache when removing symbols Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 03/16] perf ui tui progress: Implement the ui_progress_ops->finish() method Arnaldo Carvalho de Melo
2015-08-25 16:14 ` Arnaldo Carvalho de Melo [this message]
2015-08-25 16:14 ` [PATCH 05/16] perf tools: Fix Intel PT 'instructions' sample period Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 06/16] perf tools: Add Intel PT support for PSB periods Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 07/16] perf tools: Add new Intel PT packet definitions Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 08/16] perf tools: Pass Intel PT information for decoding MTC and CYC Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 09/16] perf tools: Add Intel PT support for decoding MTC packets Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 10/16] perf tools: Add Intel PT support for using " Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 11/16] perf tools: Add Intel PT support for decoding CYC packets Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 12/16] perf tools: Add Intel PT support for using " Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 13/16] perf tools: Add Intel PT support for decoding TRACESTOP packets Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 14/16] perf tools: Update Intel PT documentation Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 15/16] perf probe: Prevent segfault when reading probe point with absolute address Arnaldo Carvalho de Melo
2015-08-25 16:14 ` [PATCH 16/16] perf probe: Support probing at absolute addresses Arnaldo Carvalho de Melo
2015-08-26 0:00 ` 平松雅巳 / HIRAMATU,MASAMI
2015-08-26 12:58 ` Arnaldo Carvalho de Melo
2015-08-26 13:39 ` [GIT PULL 00/16] perf/core improvements and fixes Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440519278-623-5-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=bp@suse.de \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.