From: David Turner <dturner@twopensource.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4 3/3] untracked cache: fix entry invalidation
Date: Tue, 25 Aug 2015 15:25:01 -0400 [thread overview]
Message-ID: <1440530701.7859.3.camel@twopensource.com> (raw)
In-Reply-To: <1439989286-24355-4-git-send-email-pclouds@gmail.com>
On Wed, 2015-08-19 at 20:01 +0700, Nguyễn Thái Ngọc Duy wrote:
> First, the current code in untracked_cache_invalidate_path() is wrong
> because it can only handle paths "a" or "a/b", not "a/b/c" because
> lookup_untracked() only looks for entries directly under the given
> directory. In the last case, it will look for the entry "b/c" in
> directory "a" instead. This means if you delete or add an entry in a
> subdirectory, untracked cache may become out of date because it does not
> invalidate properly. This is noticed by David Turner.
>
> The second problem is about invalidation inside a fully untracked/excluded
> directory. In this case we may have to invalidate back to root. See the
> comment block for detail.
LGTM.
next prev parent reply other threads:[~2015-08-25 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 5:17 [PATCH v3] untracked-cache: fix subdirectory handling David Turner
2015-08-16 12:16 ` Duy Nguyen
2015-08-19 11:39 ` Duy Nguyen
2015-08-19 13:01 ` [PATCH v4 0/3] dt/untracked-subdir Nguyễn Thái Ngọc Duy
2015-08-19 13:01 ` [PATCH v4 1/3] t7063: use --force-untracked-cache to speed up a bit Nguyễn Thái Ngọc Duy
2015-08-19 13:01 ` [PATCH v4 2/3] untracked-cache: fix subdirectory handling Nguyễn Thái Ngọc Duy
2015-08-19 13:01 ` [PATCH v4 3/3] untracked cache: fix entry invalidation Nguyễn Thái Ngọc Duy
2015-08-25 19:25 ` David Turner [this message]
2015-08-25 20:12 ` Junio C Hamano
2015-08-19 17:47 ` [PATCH v4 0/3] dt/untracked-subdir Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440530701.7859.3.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.