All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org, kwolf@redhat.com
Cc: John Snow <jsnow@redhat.com>, famz@redhat.com
Subject: [Qemu-devel] [PATCH v4 1/4] iotests: fix exclusion option
Date: Tue, 25 Aug 2015 19:02:18 -0400	[thread overview]
Message-ID: <1440543741-21779-2-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1440543741-21779-1-git-send-email-jsnow@redhat.com>

If you are running out-of-tree, the -x option to exclude
a certain iotest is broken.

Replace porcelain usage of ls with a sturdier awk command.

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/qemu-iotests/common | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index 1030aaf..84b6f16 100644
--- a/tests/qemu-iotests/common
+++ b/tests/qemu-iotests/common
@@ -83,7 +83,8 @@ s/ .*//p
     elif $xgroup
     then
         # arg after -x
-        [ ! -s $tmp.list ] && ls [0-9][0-9][0-9] [0-9][0-9][0-9][0-9] >$tmp.list 2>/dev/null
+        # Populate $tmp.list with all tests
+        awk '/^[0-9]{3,}/ {print $1}' "${source_iotests}/group" > $tmp.list 2>/dev/null
         group_list=`sed -n <"$source_iotests/group" -e 's/$/ /' -e "/^[0-9][0-9][0-9].* $r /"'{
 s/ .*//p
 }'`
-- 
2.4.3

  reply	other threads:[~2015-08-25 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 23:02 [Qemu-devel] [PATCH v4 0/4] iotests: skip tests with unchanged dependencies John Snow
2015-08-25 23:02 ` John Snow [this message]
2015-08-25 23:02 ` [Qemu-devel] [PATCH v4 2/4] iotests: Add dependency info to groups list John Snow
2015-09-09 16:35   ` John Snow
2015-09-10  9:11     ` Fam Zheng
2015-09-10 14:30       ` John Snow
2015-08-25 23:02 ` [Qemu-devel] [PATCH v4 3/4] iotests: add timestamp skip feature John Snow
2015-08-25 23:02 ` [Qemu-devel] [PATCH v4 4/4] iotests: clarify help text John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440543741-21779-2-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.