From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons Date: Wed, 26 Aug 2015 05:04:01 -0700 Message-ID: <1440590641.2670.187.camel@perches.com> References: <1439911825-23536-1-git-send-email-yu.c.chen@intel.com> <20150826072221.GD50910@vmdeb7> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay0118.hostedemail.com ([216.40.44.118]:54467 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756675AbbHZMEH (ORCPT ); Wed, 26 Aug 2015 08:04:07 -0400 In-Reply-To: <20150826072221.GD50910@vmdeb7> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Darren Hart Cc: Chen Yu , akpm@linux-foundation.org, arnd@arndb.de, gregkh@linuxfoundation.org, mchehab@osg.samsung.com, davem@davemloft.net, jslaby@suse.com, tj@kernel.org, rjw@rjwysocki.net, rui.zhang@intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote: > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote: > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can > > not detect these buttons on it. According to bios implementation, > > Surface Pro 3 encapsulates these buttons in a device named "VGBI", > > with _HID "MSHW0028". When any of the buttons is pressed, a specify > > ACPI notification code for this button will be delivered to "VGBI". For > > example, if power button is pressed down, ACPI notification code of 0xc6 > > will be sent by Notify(VGBI, 0xc6). [] > Joe, you provided a lot of review, are you happy with this version? It looks fine. Thanks for picking the other little nits too Darren.